Re: [Qemu-devel] [PATCH v2 2/3] PPC: Allow little-endian user mode.

[Peter Maydell]

On 10 May 2014 10:16, Doug Kwan <address@hidden> wrote:
> This allow running PPC64 little-endian in user mode if target is configured
> that way.  In PPC64 LE user mode we set MSR.LE during initialization.
> Overhaul handling of byteswapping in code generation and mem helpers.

This looks pretty good to me (I'll let a ppc person do the detailed
review). One thing I did spot:

Outside target-ppc/, the other place we do memory accesses is
linux-user/main.c:do_store_exclusive(). get_user_u32() and friends
will honour TARGET_WORDS_BIGENDIAN, but the 128 bit store
exclusive is done with two accesses. The system-emulation mode
code handles the LE case by flipping around the register values, so
I think the linux-user code will need to do a similar thing.

thanks
-- PMM