qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset

From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH v2 8/8] x86: correctly implement soft reset
Date: Mon, 12 May 2014 11:12:16 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 
Il 12/05/2014 09:53, Andreas Färber ha scritto:

> Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset.
> These only reset the CPU.
>
> Reviewed-by: Anthony Liguori <address@hidden>
> Signed-off-by: Paolo Bonzini <address@hidden>

Apart from the question of whether cpu_soft_reset() is the right API for
this: Does this result in guest-visible changes that we need to suppress
for previous machine types?
The changes can be considered bug fixes. If anything did rely on INIT signals resetting nothing but the CPU (for example old 16-bit code that wanted to get out of protected mode), it would be broken without these changes. 

Paolo
reply via email to
[Prev in Thread] Current Thread [Next in Thread]