[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters lis
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list |
Date: |
Mon, 12 May 2014 20:57:30 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/07/2014 07:14 PM, Amos Kong wrote:
> The space before pointers is redundant.
>
> Signed-off-by: Amos Kong <address@hidden>
> ---
> scripts/qapi-visit.py | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
<rant>
Appears to be unchanged from v2. Missing the Reviewed-by I gave on v2
for the code, and you were even reminded about that in v3. I suggested
a better wording for the commit message in v2:
A space after * when declaring a pointer type is redundant.
but that still hasn't been done. It's frustrating when review comments
are not addressed (even if you don't want to make a particular change,
at least document why keeping things unchanged is preferable, rather
than silently ignoring the review).
</rant>
That said, the change is still correct, so it still deserves:
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code, Amos Kong, 2014/05/07
- [Qemu-devel] [PATCH v4 2/3] qapi: add const prefix to 'char *' insider c_type(), Amos Kong, 2014/05/07
- [Qemu-devel] [PATCH v4 3/3] qapi: Suppress unwanted space between type and identifier, Amos Kong, 2014/05/07
- [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list, Amos Kong, 2014/05/07
- Re: [Qemu-devel] [PATCH v4 1/3] qapi: fix coding style in parameters list,
Eric Blake <=
- Re: [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code, Luiz Capitulino, 2014/05/15
- Re: [Qemu-devel] [PATCH v4 0/3] qapi: fix coding style in generated code, Luiz Capitulino, 2014/05/16