Re: [Qemu-devel] [PATCH 01/18] migration: dump vmstate info as a json file for static analysis

[Amit Shah]

Hi,

On (Mon) 12 May 2014 [06:51:54], Eric Blake wrote:
> On 05/12/2014 05:16 AM, Amit Shah wrote:
> > This commit adds a new command, '-dump-vmstate', that takes a filename
> > as a parameter.  When executed, QEMU will dump the vmstate information
> > for the machine type it's invoked with to the file, and quit.
> > 
> > The JSON-format output can then be used to compare the vmstate info for
> > different QEMU versions, specifically to test whether live migration
> > would break due to changes in the vmstate data.
> 
> Are we going to document that JSON format anywhere?

I suppose we should, I thought I should wait for comments here on any
extra fields that people want.

I suppose documenting would just be coming up with a schema, though? ...

>  Is it worth making
> it part of qapi-schema.json,

but documenting the entire schema is difficult, as each device will
have its own schema text (due to the differing fields).  At least
that's how I understand it; please correct me if I'm wrong.

> whether to also expose the dump via a QMP
> command, or at a bare minimum to take advantage of some code generation
> from the qapi engine rather than doing it all by hand?

Surely -- I did give it some thought at the initial stages, but since
I've not had to modify this much since I first wrote it, and it does
work well, I'm just thinking it's alright if we do that later.  Focus
right now is on the tool itself.


                Amit