|
From: | Paolo Bonzini |
Subject: | Re: [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern |
Date: | Tue, 13 May 2014 09:08:10 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Il 13/05/2014 08:53, Andreas Färber ha scritto:
> +void do_unaligned_access(CPUAlphaState *env, target_ulong addr, > + int is_write, int is_user, uintptr_t retaddr); > + > #include "exec/exec-all.h" > > #endif /* !defined (__CPU_ALPHA_H__) */[snip] Have you considered turning this into CPUClass hooks instead, as done with do_unassigned_access? Before your patch, this was a static function used only by softmmu_template.h - making it global is not exactly helping with multi-target support. Any solution to remedy regressions appreciated.
Good idea! Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |