[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN |
Date: |
Tue, 13 May 2014 10:34:47 +0100 |
User-agent: |
mu4e 0.9.9.6pre3; emacs 24.3.91.1 |
Richard Henderson <address@hidden> writes:
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> include/exec/helper-gen.h | 12 ++++++------
> tcg/tcg-op.h | 7 -------
> 2 files changed, 6 insertions(+), 13 deletions(-)
>
> diff --git a/include/exec/helper-gen.h b/include/exec/helper-gen.h
> index abde615..208d1d2 100644
> --- a/include/exec/helper-gen.h
> +++ b/include/exec/helper-gen.h
> @@ -11,7 +11,7 @@ static inline void glue(gen_helper_,
> name)(dh_retvar_decl0(ret)) \
> { \
> int sizemask; \
> sizemask = dh_is_64bit(ret); \
> - tcg_gen_helperN(HELPER(name), flags, sizemask, dh_retvar(ret), 0, NULL); \
> + tcg_gen_callN(&tcg_ctx, HELPER(name), flags, sizemask, dh_retvar(ret), 0,
> NULL); \
> }
>
> #define DEF_HELPER_FLAGS_1(name, flags, ret, t1) \
> @@ -21,7 +21,7 @@ static inline void glue(gen_helper_,
> name)(dh_retvar_decl(ret) dh_arg_decl(t1, 1
> int sizemask = 0; \
> dh_sizemask(ret, 0); \
> dh_arg(t1, 1); \
> - tcg_gen_helperN(HELPER(name), flags, sizemask, dh_retvar(ret), 1, args); \
> + tcg_gen_callN(&tcg_ctx, HELPER(name), flags, sizemask, dh_retvar(ret), 1,
> args); \
> }
>
> #define DEF_HELPER_FLAGS_2(name, flags, ret, t1, t2) \
> @@ -33,7 +33,7 @@ static inline void glue(gen_helper_,
> name)(dh_retvar_decl(ret) dh_arg_decl(t1, 1
> dh_sizemask(ret, 0); \
> dh_arg(t1, 1); \
> dh_arg(t2, 2); \
> - tcg_gen_helperN(HELPER(name), flags, sizemask, dh_retvar(ret), 2, args); \
> + tcg_gen_callN(&tcg_ctx, HELPER(name), flags, sizemask, dh_retvar(ret), 2,
> args); \
> }
>
> #define DEF_HELPER_FLAGS_3(name, flags, ret, t1, t2, t3) \
> @@ -46,7 +46,7 @@ static inline void glue(gen_helper_,
> name)(dh_retvar_decl(ret) dh_arg_decl(t1, 1
> dh_arg(t1, 1); \
> dh_arg(t2, 2); \
> dh_arg(t3, 3); \
> - tcg_gen_helperN(HELPER(name), flags, sizemask, dh_retvar(ret), 3, args); \
> + tcg_gen_callN(&tcg_ctx, HELPER(name), flags, sizemask, dh_retvar(ret), 3,
> args); \
> }
>
> #define DEF_HELPER_FLAGS_4(name, flags, ret, t1, t2, t3, t4) \
> @@ -60,7 +60,7 @@ static inline void glue(gen_helper_,
> name)(dh_retvar_decl(ret) dh_arg_decl(t1, 1
> dh_arg(t2, 2); \
> dh_arg(t3, 3); \
> dh_arg(t4, 4); \
> - tcg_gen_helperN(HELPER(name), flags, sizemask, dh_retvar(ret), 4, args); \
> + tcg_gen_callN(&tcg_ctx, HELPER(name), flags, sizemask, dh_retvar(ret), 4,
> args); \
> }
>
> #define DEF_HELPER_FLAGS_5(name, flags, ret, t1, t2, t3, t4, t5) \
> @@ -76,7 +76,7 @@ static inline void glue(gen_helper_,
> name)(dh_retvar_decl(ret) \
> dh_arg(t3, 3); \
> dh_arg(t4, 4); \
> dh_arg(t5, 5); \
> - tcg_gen_helperN(HELPER(name), flags, sizemask, dh_retvar(ret), 5, args); \
> + tcg_gen_callN(&tcg_ctx, HELPER(name), flags, sizemask, dh_retvar(ret), 5,
> args); \
> }
>
> #include "helper.h"
> diff --git a/tcg/tcg-op.h b/tcg/tcg-op.h
> index f4367a0..719533a 100644
> --- a/tcg/tcg-op.h
> +++ b/tcg/tcg-op.h
> @@ -23,13 +23,6 @@
> */
> #include "tcg.h"
> #include "exec/helper-proto.h"
> -
> -static inline void tcg_gen_helperN(void *func, int flags, int sizemask,
> - TCGArg ret, int nargs, TCGArg *args)
> -{
> - tcg_gen_callN(&tcg_ctx, func, flags, sizemask, ret, nargs, args);
> -}
> -
> #include "exec/helper-gen.h"
>
> int gen_new_label(void);
--
Alex Bennée
- [Qemu-devel] [PATCH 00/10] tcg cleanup and optimization, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 01/10] tcg: Optimize brcond2 and setcond2 ne/eq, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 02/10] tcg: Invert the inclusion of helper.h, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 03/10] tcg: Push tcg-runtime routines into exec/helper-*, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN, Richard Henderson, 2014/05/12
- Re: [Qemu-devel] [PATCH 05/10] tcg: Inline tcg_gen_helperN,
Alex Bennée <=
- [Qemu-devel] [PATCH 06/10] tcg: Move side effects out of dh_sizemask, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 04/10] tcg: Use helper-gen.h in tcg-op.h, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 08/10] tcg: Save flags and computed sizemask in TCGHelperInfo, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 07/10] tcg: Register the helper info struct rather than the name, Richard Henderson, 2014/05/12
- [Qemu-devel] [PATCH 09/10] tcg: Remove sizemask and flags arguments to tcg_gen_callN, Richard Henderson, 2014/05/12