Re: [Qemu-devel] [PATCH v2 08/16] tpm: Convert conditional compilation of debug printfs to regular ifs

[Marc Marí]

El Tue, 13 May 2014 09:02:44 +0200
Marc Marí <address@hidden> escribió:
> diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
> index 6f0a4d2..302f2bf 100644
> --- a/hw/tpm/tpm_tis.c
> +++ b/hw/tpm/tpm_tis.c
> @@ -30,16 +30,16 @@
>  #include "qemu-common.h"
>  #include "qemu/main-loop.h"
>  
> -/*#define DEBUG_TIS */
> +/*#define DEBUG_TIS*/
>  
>  #ifdef DEBUG_TIS
> -#define DPRINTF(fmt, ...) \
> -    do { fprintf(stderr, fmt, ## __VA_ARGS__); } while (0)
> +#define DEBUG_TIS_ENABLED 1
>  #else
> -#define DPRINTF(fmt, ...) \
> -    do { } while (0)
> +#define DEBUG_TIS_ENABLED 0
>  #endif
>  
> +#define DPRINTF(fmt, ...) QEMU_DPRINTF(DEBUG_TIS_ENABLED, "tpm-tis",
> fmt, ## __VA_ARGS__) +
>  /* whether the STS interrupt is supported */
>  #define RAISE_STS_IRQ
>  

I saw that later in that file there are some DPRINTF that do not add a
\n at the end (for example in L.141). As this codes are already in a
#ifdef DEBUG_TIS, some of this DPRINTFs can be changed to fprintf in
next versions.

Marc