[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] exec-all.h: Don't use stl_p for patching x86 ju
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH] exec-all.h: Don't use stl_p for patching x86 jumps |
Date: |
Tue, 13 May 2014 09:19:10 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 09:10 AM, Peter Maydell wrote:
> On 13 May 2014 17:05, Richard Henderson <address@hidden> wrote:
>> Partial revert of 86360ad71df0070283469b8ae59f33cdd013501d,
>> because get the "wrong" version of stl_p, the one that does
>> byte swapping appropriate for the target.
>
> Whoops. We could alternatively commit the patch renaming
> the bswap.h functions to use _he_ infixes and then use
> stl_he_p() here, yes?
Yes.
> Probably best to commit this as an immediate fix though.
That's what I was thinking.
r~