[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() i
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in drive_init() |
|
Date: |
Tue, 13 May 2014 11:04:05 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 10:02 AM, Markus Armbruster wrote:
> qerror_report_err() is a transitional interface to help with
> converting existing HMP commands to QMP. It should not be used
> elsewhere.
>
> drive_init() is not meant to be used by QMP commands. It uses both
> qerror_report_err() and error_report(). Convert the former to the
> latter.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> blockdev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 00/18] [PATCH 00/18] block: Purge qerror_report(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 03/18] qemu-nbd: Don't use qerror_report(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 02/18] blockdev: Don't use qerror_report() in do_drive_del(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in drive_init(), Markus Armbruster, 2014/05/13
- Re: [Qemu-devel] [PATCH 01/18] blockdev: Don't use qerror_report_err() in drive_init(),
Eric Blake <=
- [Qemu-devel] [PATCH 08/18] block/ssh: Propagate errors through connect_to_ssh(), Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 04/18] block/rbd: Propagate errors to open and create methods, Markus Armbruster, 2014/05/13
- [Qemu-devel] [PATCH 05/18] block/ssh: Drop superfluous libssh2_session_last_errno() calls, Markus Armbruster, 2014/05/13