[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/4] curl: Fix parsing of readahead option from filename |
Date: |
Tue, 13 May 2014 11:29:08 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/08/2014 02:42 AM, Matthew Booth wrote:
> curl_parse_filename wasn't removing the option string from the url,
> resulting in a 404.
>
> This change is a rewrite of the previous parsing behaviour, and
> also changes the option syntax. The new syntax is:
>
> http://example.com/path?query[sslverify=off:readahead=64k]
Again, I'm not sure I'm happy with this - we shouldn't be inventing our
own syntax when URI is already a well-defined syntax.
>
> The new syntax is well defined as long as square brackets in the URI
> are escaped.
>
> This change is also preparation for the addition of more options.
>
> Signed-off-by: Matthew Booth <address@hidden>
> ---
> block/curl.c | 101
> +++++++++++++++++++++++++++++++++++++++--------------------
> 1 file changed, 67 insertions(+), 34 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] Curl updates, Matthew Booth, 2014/05/08
- [Qemu-devel] [PATCH 3/4] curl: Add usage documentation, Matthew Booth, 2014/05/08
- [Qemu-devel] [PATCH 2/4] curl: Add sslverify option, Matthew Booth, 2014/05/08
- [Qemu-devel] [PATCH 4/4] curl: Fix build when curl_multi_socket_action isn't available, Matthew Booth, 2014/05/08
- Re: [Qemu-devel] Curl updates, Eric Blake, 2014/05/13