Re: [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set_property

[Andreas Färber]

Am 07.05.2014 16:42, schrieb Marcel Apfelbaum:
> Filter out also 'type' property when setting
> object's properties
> 
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
>  vl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/vl.c b/vl.c
> index 58673bd..6ec6c1a 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2889,7 +2889,8 @@ static int object_set_property(const char *name, const 
> char *value, void *opaque
>      StringInputVisitor *siv;
>      Error *local_err = NULL;
>  
> -    if (strcmp(name, "qom-type") == 0 || strcmp(name, "id") == 0) {
> +    if (strcmp(name, "qom-type") == 0 || strcmp(name, "id") == 0 ||
> +        strcmp(name, "type") == 0) {
>          return 0;
>      }
>  

Seems sensible, although qom-type and type looks kind of odd at first.

Given the Rb on this v1 patch, is this applied in any tree already?

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg