Re: [Qemu-devel] [PATCH v2 1/2] SMBIOS: Fix endian-ness when populating fields wider than 8-bit

[Paolo Bonzini]

Il 13/05/2014 20:17, Gabriel L. Somlo ha scritto:
> -    t->processor_id[0] = smbios_cpuid_version;
> -    t->processor_id[1] = smbios_cpuid_features;
> +    t->processor_id[0] = smbios_cpuid_version; /* opaque, no cpu_to_le16 */
> +    t->processor_id[1] = smbios_cpuid_features; /* opaque, no cpu_to_le16 */

Actually I think these should be subject to cpu_to_le32.  They 
correspond to CPUID values, so they are little-endian 32-bit.

Paolo