[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames |
Date: |
Tue, 13 May 2014 16:12:59 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/08/2014 12:12 PM, Max Reitz wrote:
> If the filename given to bdrv_open() is prefixed with "json:", parse the
> rest as a JSON object and merge the result into the options QDict. If
> there are conflicts, report one of them to the user and abort.
Commit message is stale compared to change in the code.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block.c | 41 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 41 insertions(+)
Code is find, though, so:
Reviewed-by: Eric Blake <address@hidden>
> +
> + /* Options given in the filename have lower priority than options
> + * specified directly */
> + qdict_join(options, json_options, false);
> + QDECREF(json_options);
> + filename = NULL;
> + }
> +
> bs->options = options;
> options = qdict_clone_shallow(options);
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 0/4] block: Allow JSON filenames, Max Reitz, 2014/05/08
- [Qemu-devel] [PATCH v3 1/4] qdict: Add qdict_join(), Max Reitz, 2014/05/08
- [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames, Max Reitz, 2014/05/08
- Re: [Qemu-devel] [PATCH v3 3/4] block: Allow JSON filenames,
Eric Blake <=
- [Qemu-devel] [PATCH v3 2/4] check-qdict: Add test for qdict_join(), Max Reitz, 2014/05/08
- [Qemu-devel] [PATCH v3 4/4] iotests: Add test for the JSON protocol, Max Reitz, 2014/05/08
- Re: [Qemu-devel] [PATCH v3 0/4] block: Allow JSON filenames, Kevin Wolf, 2014/05/14