qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Curl updates


From: Kevin Wolf
Subject: Re: [Qemu-devel] Curl updates
Date: Wed, 14 May 2014 09:48:17 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 13.05.2014 um 21:47 hat Eric Blake geschrieben:
> On 05/08/2014 02:42 AM, Matthew Booth wrote:
> > [PATCH 1/4] curl: Fix parsing of readahead option from filename
> > [PATCH 2/4] curl: Add sslverify option
> > [PATCH 3/4] curl: Add usage documentation
> > 
> > The first 3 patches are reposted with updates following discussion of the 
> > option
> > syntax. With this patch I've decided to break entirely with the previous 
> > syntax.
> > Given that option parsing was previously both broken and undocumented, this 
> > is
> > hopefully a forgivable sin.
> > 
> > The new syntax is:
> > 
> >   http://user:address@hidden/path?query[opt1=val:opt2=val]
> > 
> > I've bounded the option block in square brackets as these have no semantic
> > meaning in any of the supported URI formats.
> 
> Offhand, I'm not liking this.  Why not use a completely valid URI, with
> '.../path?query&opt1=val&opt2=val'?  Inventing your own
> [opt1=val:opt2=val] on top of URI is asking for confusion.
> 
> Are you trying to support a way to pass a query string to the curl URI,
> in addition to local options?  How often do curl URIs need a query?

My guess would be that you need this more often than local options.

Anyway, let's not add new options encoded in the URL, but point users to
separate options. We may decide that we need the support the old crude
way of encoding local options for compatibility, but preferably I would
make filename just a plain URL.

Kevin

Attachment: pgpMqC0eJfVjW.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]