Re: [Qemu-devel] [PULL 03/17] qemu-img: sort block formats in help message

[Stefan Hajnoczi]

On Tue, May 13, 2014 at 11:40:47AM -0400, Mike Day wrote:
> On Tue, May 13, 2014 at 10:18 AM, Cornelia Huck
> <address@hidden> wrote:
> >
> > qemu-img.o: In function `add_format_to_seq':
> > /home/cohuck/git/qemu/qemu-img.c:73: undefined reference to 
> > `g_sequence_lookup'
> > collect2: ld returned 1 exit status
> >
> > g_sequence_lookup has been added with glib 2.28, and this box has
> > 2.22.5. configure looks for glib >= 2.12 (2.20 for mingw).
> 
> g_sequence_lookup is there because I was getting duplicate formats in
> the format list, as in "vfat vfat vfat qcow." That was a temporary
> situation. the lookup serves to guarantee each format is unique in the
> list. It may not be needed.

Jeff Cody recently wanted to eliminate duplicate entries in the list.  I
thought part of your intention was to address the duplicates with your
patch.

We can back out the sequence API if it's not supported on older glib but
it would be nice to eliminate duplicates later, too.

Stefan