Re: [Qemu-devel] [RFC PATCH V5 1/8] update-linux-headers.sh: Add psci.h to linux header sync-up script

[Peter Maydell]

On 12 May 2014 13:37, Pranavkumar Sawargaonkar <address@hidden> wrote:
> We will be using linux/psci.h for KVM ARM/ARM64 hence add it to
> linux header sync-up script.
>
> Signed-off-by: Pranavkumar Sawargaonkar <address@hidden>
> Signed-off-by: Anup Patel <address@hidden>
> ---
>  scripts/update-linux-headers.sh |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh
> index 120a694..eec3f40 100755
> --- a/scripts/update-linux-headers.sh
> +++ b/scripts/update-linux-headers.sh
> @@ -61,7 +61,7 @@ done
>
>  rm -rf "$output/linux-headers/linux"
>  mkdir -p "$output/linux-headers/linux"
> -for header in kvm.h kvm_para.h vfio.h vhost.h virtio_config.h virtio_ring.h; 
> do
> +for header in kvm.h kvm_para.h vfio.h vhost.h virtio_config.h virtio_ring.h 
> psci.h; do

A couple of nits:
 * would be nice to keep the list of .h files in alphabetical order
 * this line is now longer than 80 characters so needs breaking

Otherwise looks good.

thanks
-- PMM