qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 10/18] block/vvfat: Propagate errors through ena


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH 10/18] block/vvfat: Propagate errors through enable_write_target()
Date: Wed, 14 May 2014 10:57:39 -0600
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

On 05/13/2014 10:02 AM, Markus Armbruster wrote:
> Continues the conversion of the open method to Error started in commit
> 015a103.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  block/vvfat.c | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 

>      s->qcow = NULL;
>      ret = bdrv_open(&s->qcow, s->qcow_filename, NULL, NULL,
>              BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, bdrv_qcow,
> -            &local_err);
> +            errp);

Pre-existing; indentation looks odd here if you want to touch it up at
the same time.  But that's not a show-stopper.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]