Re: [Qemu-devel] [PATCH 10/18] block/vvfat: Propagate errors through enable_write_target()

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 05/13/2014 10:02 AM, Markus Armbruster wrote:
>> Continues the conversion of the open method to Error started in commit
>> 015a103.
>> 
>> Signed-off-by: Markus Armbruster <address@hidden>
>> ---
>>  block/vvfat.c | 16 ++++++----------
>>  1 file changed, 6 insertions(+), 10 deletions(-)
>> 
>
>>      s->qcow = NULL;
>>      ret = bdrv_open(&s->qcow, s->qcow_filename, NULL, NULL,
>>              BDRV_O_RDWR | BDRV_O_CACHE_WB | BDRV_O_NO_FLUSH, bdrv_qcow,
>> -            &local_err);
>> +            errp);
>
> Pre-existing; indentation looks odd here if you want to touch it up at
> the same time.  But that's not a show-stopper.

Can take care of it when I respin to correct the leak in 04/18.

> Reviewed-by: Eric Blake <address@hidden>

Thanks!