[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature filtering/c
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature filtering/checking functions |
Date: |
Thu, 15 May 2014 15:19:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 30.04.2014 18:48, schrieb Eduardo Habkost:
> Merge filter_features_for_kvm() and kvm_check_features_against_host().
>
> Both functions made exactly the same calculations, the only difference
> was that filter_features_for_kvm() changed the bits on cpu->features[],
> and kvm_check_features_against_host() did error reporting.
>
> Reviewed-by: Richard Henderson <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
Applying minor style tweak towards gtk-doc:
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 6302a5c..f022ef3 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -1819,11 +1819,12 @@ CpuDefinitionInfoList
*arch_query_cpu_definitions(Error **errp)
return cpu_list;
}
-/* Filters CPU feature words based on host availability of each feature
- *
- * Returns 0 if all flags are supported by the host, non-zero otherwise.
+/*
+ * Filters CPU feature words based on host availability of each feature.
*
* This function may be called only if KVM is enabled.
+ *
+ * Returns: 0 if all flags are supported by the host, non-zero otherwise.
*/
static int filter_features_for_kvm(X86CPU *cpu)
{
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH v4 03/18] target-i386: Merge feature filtering/checking functions,
Andreas Färber <=