Re: [Qemu-devel] [PATCH RESEND v4 16/18] savevm: check vmsd for migratability status

[Juan Quintela]

Andreas Färber <address@hidden> wrote:
> Am 15.05.2014 14:14, schrieb Juan Quintela:
>> Eduardo Habkost <address@hidden> wrote:
>>> From: Marcelo Tosatti <address@hidden>
>>>
>>> Check vmsd for unmigratable field, allowing migratibility status
>>> to be modified after vmstate_register.
>>>
>>> Cc: Juan Quintela <address@hidden>
>>> Signed-off-by: Marcelo Tosatti <address@hidden>
>>> Reviewed-by: Eduardo Habkost <address@hidden>
>>> Signed-off-by: Eduardo Habkost <address@hidden>
>> 
>> I agree with the patch spirt, but what happens if we want to disable
>> migration in a device that has no VMSD?
>
> As the patch shows, no non-VMSD device setting no_migrate exists today.
> Do you expect any to appear? I'm rather seeing more and more devices
> getting converted to VMSD.

I want people to notice that.  As said, I hope that everything new uses
VMSD.

Later, Juan.