Re: [Qemu-devel] [PATCH 3/4] vl.c: do not set 'type' property in obj_set_property

[Markus Armbruster]

Marcel Apfelbaum <address@hidden> writes:

> Filter out also 'type' property when setting
> object's properties
>
> Reviewed-by: Paolo Bonzini <address@hidden>
> Signed-off-by: Marcel Apfelbaum <address@hidden>
> ---
>  vl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index 58673bd..6ec6c1a 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2889,7 +2889,8 @@ static int object_set_property(const char *name, const 
> char *value, void *opaque
>      StringInputVisitor *siv;
>      Error *local_err = NULL;
>  
> -    if (strcmp(name, "qom-type") == 0 || strcmp(name, "id") == 0) {
> +    if (strcmp(name, "qom-type") == 0 || strcmp(name, "id") == 0 ||
> +        strcmp(name, "type") == 0) {
>          return 0;
>      }

I can see why "id" and "qom-type" need to be filtered out: they're
consumed by object_create() before object_set_property() gets called.

I can't see why "type".  Explain?