[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 00/12] qapi: Purge error_is_set()
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v2 00/12] qapi: Purge error_is_set() |
Date: |
Thu, 15 May 2014 14:11:17 -0400 |
On Wed, 7 May 2014 09:53:42 +0200
Markus Armbruster <address@hidden> wrote:
> This is the sixth part, covering QAPI and its users. Luiz agreed to
> take this through his tree.
>
> PATCH 01-08 are preparatory cleanups.
>
> PATCH 09-11 fix misuses of the visitor API in hand-written code.
> Generated code uses the API correctly.
>
> PATCH 12 converts QAPI and its users to the common use of the error
> API, purging error_is_set() along the way.
>
> v1 has a PATCH 13 that drops error_is_set(). This depends on all five
> prior parts of the purge, of which only the first two have been
> committed already. Luiz asked me to drop it from this series.
>
> My series conflicts with LluĂs's "qapi: Allow modularization of QAPI
> schema files" and Amos's "qapi: fix coding style in generated code",
> but the conflicts are trivial, and 3-way merge can take care of them.
>
> v2:
> * Fix pasto in commit messages of PATCH 10+11 [Eric]
> * Fix logic error in PATCH 12 [Eric]
> * Update copyright notice in PATCH 12
> * Unbundle PATCH 13
Applied to the qmp branch, thanks.
>
> Markus Armbruster (12):
> qapi: Update qapi-code-gen.txt example to match current code
> qapi: Normalize marshalling's visitor initialization and cleanup
> qapi: Remove unused Visitor callbacks start_handle(), end_handle()
> qapi: Replace start_optional()/end_optional() by optional()
> qapi-visit.py: Clean up confusing push_indent() / pop_indent() use
> qapi: Clean up shadowing of parameters and locals in inner scopes
> qapi-visit.py: Clean up a sloppy use of field prefix
> qapi: Un-inline visit of implicit struct
> hmp: Call visit_end_struct() after visit_start_struct() succeeds
> hw: Don't call visit_end_struct() after visit_start_struct() fails
> tests: Don't call visit_end_struct() after visit_start_struct() fails
> qapi: Replace uncommon use of the error API by the common one
>
> docs/qapi-code-gen.txt | 165 ++++++++++++++---------
> hmp.c | 16 +--
> hw/timer/mc146818rtc.c | 41 +++++-
> hw/virtio/virtio-balloon.c | 33 +++--
> include/qapi/visitor-impl.h | 8 +-
> include/qapi/visitor.h | 5 +-
> qapi/opts-visitor.c | 5 +-
> qapi/qapi-visit-core.c | 259
> +++++++++++++++----------------------
> qapi/qmp-input-visitor.c | 6 +-
> qapi/string-input-visitor.c | 6 +-
> scripts/qapi-commands.py | 89 ++++++++-----
> scripts/qapi-visit.py | 232 +++++++++++++++++++--------------
> tests/test-qmp-input-strict.c | 28 +++-
> tests/test-qmp-input-visitor.c | 26 ++--
> tests/test-qmp-output-visitor.c | 28 +++-
> tests/test-visitor-serialization.c | 26 +++-
> 16 files changed, 558 insertions(+), 415 deletions(-)
>
- [Qemu-devel] [PATCH v2 05/12] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use, (continued)
- [Qemu-devel] [PATCH v2 05/12] qapi-visit.py: Clean up confusing push_indent() / pop_indent() use, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 02/12] qapi: Normalize marshalling's visitor initialization and cleanup, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 07/12] qapi-visit.py: Clean up a sloppy use of field prefix, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 04/12] qapi: Replace start_optional()/end_optional() by optional(), Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 12/12] qapi: Replace uncommon use of the error API by the common one, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 11/12] tests: Don't call visit_end_struct() after visit_start_struct() fails, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 06/12] qapi: Clean up shadowing of parameters and locals in inner scopes, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 08/12] qapi: Un-inline visit of implicit struct, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 10/12] hw: Don't call visit_end_struct() after visit_start_struct() fails, Markus Armbruster, 2014/05/07
- [Qemu-devel] [PATCH v2 09/12] hmp: Call visit_end_struct() after visit_start_struct() succeeds, Markus Armbruster, 2014/05/07
- Re: [Qemu-devel] [PATCH v2 00/12] qapi: Purge error_is_set(),
Luiz Capitulino <=