Re: [Qemu-devel] [PATCH v4 14/18] target-i386: Add "migratable" property to "host" CPU model

[Eduardo Habkost]

On Thu, May 15, 2014 at 09:44:49PM +0200, Andreas Färber wrote:
> Am 30.04.2014 18:48, schrieb Eduardo Habkost:
> > This flag will allow the user to choose between two modes:
> >  * All flags that can be enabled on the host, even if unmigratable
> >    (migratable=no);
> >  * All flags that can be enabled on the host, known to QEMU,
> >    and migratable (migratable=yes).
> > 
> > The default is still migratable=false, to keep current behavior, but
> > this will be changed to migratable=true by another patch.
> > 
> > My plan was to support the "migratable" flag on all CPU classes, but
> > have the default to "false" on all CPU models except "host". However,
> > DeviceClass has no mechanism to allow a child class to have a different
> > property default from the parent class yet, so by now only the "host"
> > CPU model will support the "migratable" flag.
> 
> Just set the new default in the derived type's instance_init?

That would work. I am still assuming that one day we will allow
management to query for class property defaults without instantiating
objects. But even if we do it, "host" is already an exception (because
the defaults depend on KVM initialization), so in this case it will be
OK.

So, this patch can be dropped because it will be replaced. I will also
implement the other changes you requested for this patch.

Thanks,

-- 
Eduardo