Re: [Qemu-devel] [PATCH 1/3] target-i386: fix segment flags for SMM and VM86 mode

[Paolo Bonzini]

Il 15/05/2014 20:45, Kevin O'Connor ha scritto:
> On Thu, May 15, 2014 at 06:56:54PM +0200, Paolo Bonzini wrote:
> > With the next patch, these need to be correct or VM86 tasks
> > have the wrong CPL.  The flags are basically what the Intel VMX
> > documentation say is mandatory for entry into a VM86 guest.
> >
> > For consistency, SMM ought to have the same flags except with
> > CPL=0.
>
> Does cpu_x86_load_seg() and x86_cpu_gdb_load_seg() then also have to
> change?

The former is just for user-mode emulation, but it probably doesn't hurt 
to fix it (I just found out about tests/tcg/runcom.c, which can be used 
to test this code path).  For the latter you're right, thanks!

Paolo