Re: [Qemu-devel] [PATCH v1 RFC 0/6] KVM: s390: cpu model implementation

[Christian Borntraeger]

On 13/05/14 16:58, Michael Mueller wrote:
> The proposed patch set implements S390 cpu model support in kvm. A cpu
> model is defined by a triple comprizing the cpu type , the cpu facility
> set and instruction blocking control. A consumer requests a feasible
> combination of that that triple before vcpu creation. All subsequently
> created vcpu's will use this cpu configuration. 
> 
> Michael Mueller (6):
>   s390/sclp: add sclp_get_ibc function
>   KVM: s390: split SIE state guest prefix field
>   KVM: s390: use facilities and cpu_id per KVM
>   KVM: s390: add ibc api
>   KVM: s390: initial implementation of soft facilities
>   KVM: s390: add cpu model support
> 
>  arch/s390/include/asm/kvm_host.h |  13 +-
>  arch/s390/include/asm/sclp.h     |   1 +
>  arch/s390/include/uapi/asm/kvm.h |  23 ++++
>  arch/s390/kvm/Makefile           |   2 +-
>  arch/s390/kvm/diag.c             |   2 +-
>  arch/s390/kvm/gaccess.c          |   4 +-
>  arch/s390/kvm/gaccess.h          |   8 +-
>  arch/s390/kvm/ibc.c              |  29 +++++
>  arch/s390/kvm/kvm-s390.c         | 263 
> +++++++++++++++++++++++++++++++++------
>  arch/s390/kvm/kvm-s390.h         |  43 ++++++-
>  arch/s390/kvm/priv.c             |  16 ++-
>  arch/s390/kvm/softfac.c          |  38 ++++++
>  drivers/s390/char/sclp_early.c   |  12 +-
>  13 files changed, 397 insertions(+), 57 deletions(-)
>  create mode 100644 arch/s390/kvm/ibc.c
>  create mode 100644 arch/s390/kvm/softfac.c
> 

I will add patch 1 and 2 to the next KVM: s390: pull request as there 
does not seem to be potential for discussion / interface changes. 
Everything else looks ok, but I want to wait if additional feedback 
about the overall design comes in. 

Christian