Re: [Qemu-devel] [PATCH 8/9] PPC: Add u-boot firmware for e500

[Gerd Hoffmann]

  Hi,

> +u-boot.e500:
> +    # examples fail to honor cflags, just remove them
> +    rm -rf u-boot/examples
> +    sed -i 's/examples//g' u-boot/Makefile
> +    # Make linker script biarch aware
> +    sed -i 's/OUTPUT_ARCH(powerpc)/OUTPUT_ARCH(powerpc:common)/' \
> +        u-boot/arch/powerpc/cpu/mpc85xx/u-boot.lds

Hmm.  Mucking with the source tree like this will leave the u-boot git
tree in a dirty state, which isn't exactly nice.  Fixable by sprinkling
in a "git reset --hard", but that obviously has other downsides, such as
seriously disturbing people trying to build a u-boot tree with local
changes.

Any chance to fix that without patching the source tree, by passing
SUBDIRS="<list-dirs-without-examples>" to $(MAKE) for example?
Or send patches to u-boot upstream to tackle this?

> +    # Compile u-boot
> +    $(MAKE) -C u-boot O=build.e500 qemu-ppce500_config
> +    $(MAKE) -C u-boot CROSS_COMPILE=$(powerpc64_cross_prefix) \
> +        O=build.e500 KCFLAGS=-m32 KAFLAGS=-m32 \
> +        LDFLAGS=-melf32ppc KCPPFLAGS=-m32 V=1 u-boot.bin
> +    strip u-boot/build.e500/u-boot -o ../pc-bios/u-boot.e500

$(powerpc64_cross_prefix)strip I guess ...

cheers,
  Gerd