Re: [Qemu-devel] [PATCH v5] libxl: add basic spice support for pv domUs

[Ian Campbell]

On Fri, 2014-05-16 at 15:41 +0200, Fabio Fantoni wrote:
> Il 16/05/2014 14:47, Ian Campbell ha scritto:
> > On Fri, 2014-05-16 at 14:37 +0200, Fabio Fantoni wrote:
> >> This patch adds basic spice support for pv domUs.
> >> The qemu parameters are the same as the hvm ones and they works.
> >> Therefore xl cfg parameters are the same as the hvm ones except that
> >> features not supported yet by pv domUs (vdagent and usbredirection)
> >> are kept disabled by default.
> >> It also enables vfb and vkb required to have basic spice working.
> > Based on your response in <address@hidden> I'm not sure if this
> > an accurate description of what you are doing here. AFAICT what you are
> > actually doing is enabling SPICE as a backend for the PVFB device, as an
> > alternative to VNC and SDL. Is that correct or not?
> Yes,

In that case then these spice settings should be part of
libxl_device_vfb, like the vnc ones are and they should configurable in
xl configuration files as:

        vfb = [ 'spice=1,spiceport=NNN' ]

There should be no need to move the HVM spice parameters to the top
level of the domain configuration. I'm afraid my previous advice was
based on an incorrect understanding of what you were implementing
(derived from the commit message not being clear about what was actually
going on).

> The only 2 main problem reimained with spice I think that are qxl not 
> working on linux domUs(xen related)

Given the lack of clarity shown so far about what this existing patch is
actually doing doing I'm a little concerned about how QXL is going to
fit into the model in the future.

Ian.