[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-mips: pass CPUMIPSState to gen_mfc0/
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-mips: pass CPUMIPSState to gen_mfc0/mtc0/dmfc0/dmtc0 |
|
Date: |
Sat, 17 May 2014 11:03:16 -0700 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/16/2014 11:13 AM, Petar Jovanovic wrote:
>
> -static void gen_mfc0(DisasContext *ctx, TCGv arg, int reg, int sel)
> +static void gen_mfc0(CPUMIPSState *env, DisasContext *ctx,
> +
You should not be passing around env within the translator, at all.
You should be able to get everything you need from ctx->hflags
or ctx->insn_flags. If there's something missing from ctx, then
we'll talk about additional changes.
r~