[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] nbd: Don't export a block de
|
From: |
Michael Tokarev |
|
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 1/2] nbd: Don't export a block device with no medium. |
|
Date: |
Mon, 19 May 2014 12:00:10 +0400 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 |
18.05.2014 14:50, Hani Benhabiles wrote:
> The device is exported with erroneous values and can't be read.
>
> Before the patch:
> $ sudo nbd-client localhost -p 10809 /dev/nbd0 -name floppy0
> Negotiation: ..size = 17592186044415MB
> bs=1024, sz=18446744073709547520 bytes
>
> $ sudo mount /dev/nbd0 /mnt/tmp/
> mount: block device /dev/nbd0 is write-protected, mounting read-only
> mount: /dev/nbd0: can't read superblock
>
> After the patch:
> (qemu) nbd_server_add ide0-hd0
> (qemu) nbd_server_add floppy0
> Device 'floppy0' has no medium
I'm not sure this is the right direction. Maybe we should actually
allow exporting devices with no medium to be able to insert medium
later without re-starting the server? Especially with -t (persistent).
I dunno. At least this is the decision which should not be left to
a -trivial tree.
Thank you!
/mjt