qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH RFC V2 0/8] virtio: migrate new properties
Date: Mon, 19 May 2014 18:10:08 +0300

On Mon, May 19, 2014 at 02:02:39PM +0200, Alexander Graf wrote:
> 
> On 19.05.14 10:38, Greg Kurz wrote:
> >Hi,
> >
> >This patch set tries to address comments from the initial
> >review. For this round, I have focused on two changes:
> >- as suggested by Andreas, we now call the device specific
> >   code from the generic code to ease the implementation of
> >   future devices. This is achieved with the addition of
> >   load/save methods to VirtioDeviceClass.
> >- virtio subsections now implement a "needed" concept with
> >   the same semantics as in the VMState code.
> >
> >I haven't looked at compat mode issues yet, but it is
> >on my TODO list.
> 
> If you fix up the comments to be either
> 
>   /*
>    * foo
>    */
> 
> or
> 
>   /* foo */
> 
> style, not
> 
>   /* foo
>    */
> 
> then you get my
> 
> 
> Acked-by: Alexander Graf <address@hidden>
> 
> 
> Alex

Documented anywhere?
Linux style is

        /* Always
         * like this.
         */

so it's definitely not universal.


-- 
MST



reply via email to

[Prev in Thread] Current Thread [Next in Thread]