[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp) |
|
Date: |
Mon, 19 May 2014 11:14:23 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/19/2014 10:57 AM, Markus Armbruster wrote:
> Using error_is_set(errp) to check whether a function call failed is
> fragile: it breaks when errp is null. Check perfectly suitable return
> values instead when possible. As far as I can tell, errp can't be
> null there, but this is more robust and more obviously correct
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-char.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] char: Purge error_is_set(), Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp), Markus Armbruster, 2014/05/19
- Re: [Qemu-devel] [PATCH v2 1/5] char: Use return values instead of error_is_set(errp),
Eric Blake <=
- [Qemu-devel] [PATCH v2 3/5] char: Explain qmp_chardev_add()'s unusual error handling, Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 4/5] qemu-socket: Clean up inet_connect_opts(), Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 5/5] error: error_is_set() is finally unused; remove, Markus Armbruster, 2014/05/19
- [Qemu-devel] [PATCH v2 2/5] char: Clean up fragile use of error_is_set(), Markus Armbruster, 2014/05/19