[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Put tempfiles in a subdir of the bui
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Put tempfiles in a subdir of the build directory |
Date: |
Mon, 19 May 2014 18:50:37 +0100 |
On 19 May 2014 18:46, Eric Blake <address@hidden> wrote:
> On 05/19/2014 11:19 AM, Peter Maydell wrote:
>> -# NB: do not call "exit" in the trap handler; this is buggy with some
>> shells;
>> -# see <address@hidden>
>> -trap "rm -f $TMPC $TMPO $TMPCXX $TMPE" EXIT INT QUIT TERM
>
> While we don't need a trap that jumps through hoops, it may still be
> nice to have a 'rm -r ${TMPDIR1}' at the end of configure. Just because
> we cleanup a leftover config-temp on start from an earlier aborted run
> doesn't mean that a clean run shouldn't clean up after itself.
Yeah, I was in two minds about that, but you're right that
it's a little neater to clean up after a successful run.
thanks
-- PMM