[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPR
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF |
Date: |
Mon, 19 May 2014 15:07:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/17/2014 05:03 PM, Marc Marí wrote:
> Modify debug macros to have the same format through the codebase and use
> regular
> ifs instead of ifdef.
>
> As the debug printf is always put in code, some formats had to be changed to
> avoid warnings treated as errors at compile time..
>
> Signed-off-by: Marc Marí <address@hidden>
> ---
> hw/isa/vt82c686.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>
> - DPRINTF("superio_ioport_writeb address 0x%x val 0x%x\n", addr, data);
> + DPRINTF("superio_ioport_writeb address 0x%" PRIx64 " val 0x%" PRIx64
> "\n",
Any reason you shortened one double space but left the other intact? I
would have expected both or none.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 04/16] scsi: Convert debug printfs to QEMU_DPRINTF, (continued)
- [Qemu-devel] [PATCH v3 04/16] scsi: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 05/16] highbank: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 06/16] xilinx: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 09/16] i82374: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 08/16] stellaris: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 10/16] i8257: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 11/16] rc4030: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 12/16] sd: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF,
Eric Blake <=
- [Qemu-devel] [PATCH v3 14/16] lan9118: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 16/16] common: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17
- [Qemu-devel] [PATCH v3 15/16] pci-host: Convert debug printfs to QEMU_DPRINTF, Marc Marí, 2014/05/17