Re: [Qemu-devel] [PATCH v3.1 25/31] hostmem: add properties for NUMA memory policy

[Eduardo Habkost]

On Tue, May 06, 2014 at 05:27:46PM +0800, Hu Tao wrote:\
[...]
> +static void
> +set_host_nodes(Object *obj, Visitor *v, void *opaque, const char *name,
> +               Error **errp)
> +{
> +#ifdef CONFIG_NUMA
> +    HostMemoryBackend *backend = MEMORY_BACKEND(obj);
> +    uint16List *l = NULL;
> +
> +    visit_type_uint16List(v, &l, name, errp);
> +
> +    while (l) {
> +        bitmap_set(backend->host_nodes, l->value, 1);

Shouldn't we clear the existing bits, here?

> +        l = l->next;
> +    }
> +#else
> +    error_setg(errp, "NUMA node binding are not supported by this QEMU");
> +#endif
> +}

-- 
Eduardo