Re: [Qemu-devel] [PATCH v19 02/16] block: Add BlockOpType enum

[Fam Zheng]

On Mon, 05/19 18:15, Markus Armbruster wrote:
> Eric Blake <address@hidden> writes:
> 
> > On 05/11/2014 07:35 PM, Fam Zheng wrote:
> >> This adds the enum of all the operations that can be taken on a block
> >> device.
> >> 
> >> Signed-off-by: Fam Zheng <address@hidden>
> >> Reviewed-by: Benoit Canet <address@hidden>
> >> Reviewed-by: Jeff Cody <address@hidden>
> >> ---
> >>  include/block/block.h | 19 +++++++++++++++++++
> >>  1 file changed, 19 insertions(+)
> >
> > Is it worth making this a formal QAPI enum, documented in the .json
> > file? If we ever add qapi introspection, it might be nice to know when
> > new block op types are added as part of the formal qapi definition.
> 
> Moving it into the schema when QAPI needs it shouldn't be hard.
> 

Yes. It was a QAPI enum before v9. The previous discussion about this was in v8
series, where I decided to keep this internal only:

http://patchwork.ozlabs.org/patch/300933/

Fam