Re: [Qemu-devel] [PATCH v3 13/16] isa: Convert debug printfs to QEMU_DPRINTF

[Marc Marí]

El Mon, 19 May 2014 15:07:18 -0600
Eric Blake <address@hidden> escribió:
> On 05/17/2014 05:03 PM, Marc Marí wrote:
> > Modify debug macros to have the same format through the codebase
> > and use regular ifs instead of ifdef.
> > 
> > As the debug printf is always put in code, some formats had to be
> > changed to avoid warnings treated as errors at compile time..
> > 
> > Signed-off-by: Marc Marí <address@hidden>
> > ---
> >  hw/isa/vt82c686.c |   12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> > 
> 
> >  
> > -    DPRINTF("superio_ioport_writeb  address 0x%x  val 0x%x\n",
> > addr, data);
> > +    DPRINTF("superio_ioport_writeb address 0x%" PRIx64 "  val 0x%"
> > PRIx64 "\n",
> 
> Any reason you shortened one double space but left the other intact?
> I would have expected both or none.
> 

That's a typo. I wanted to left it as it was (double space in both
places).