Re: [Qemu-devel] [PATCH] -machine vmport=off: Allow disabling of VMWare ioport emulation

[Dr. David Alan Gilbert]

* Gerd Hoffmann (address@hidden) wrote:
> >      /* init basic PC hardware */
> > -    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy, xen_enabled(),
> > -        0x4);
> > +    pc_basic_device_init(isa_bus, gsi, &rtc_state, &floppy,
> > +                         !qemu_opt_get_bool(qemu_get_machine_opts(), 
> > "vmport",
> > +                                            true) || xen_enabled(), 0x4);
> 
> pc_basic_device_init
>   (isa_bus, gsi, &rtc_state, &floppy,
>    !qemu_opt_get_bool(qemu_get_machine_opts(),"vmport",!xen_enabled()),
>    0x4);
> 
> ?
> 
> This makes vmport switchable on xen too, with traditional behavior being
> the default (off on xen, on otherwise).

Yes I guess that would work (although documenting it would be a little hairy);
however, does anyone understand the reasons it's disabled in the Xen world?

Dave
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK