qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc


From: Alexander Graf
Subject: Re: [Qemu-devel] [PATCH v2] kvm: Fix enable_cap helpers on older gcc
Date: Tue, 20 May 2014 12:53:34 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:24.0) Gecko/20100101 Thunderbird/24.5.0


On 20.05.14 12:53, Cornelia Huck wrote:
On Mon, 12 May 2014 11:51:37 +0200
Alexander Graf <address@hidden> wrote:

Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on
vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6)
seem to choke on signedness detection in inline created variables:

target-ppc/kvm.c: In function 'kvmppc_booke_watchdog_enable':
target-ppc/kvm.c:1302:21: error: comparison of unsigned expression < 0 is 
always false [-Werror=type-limits]
target-ppc/kvm.c: In function 'kvmppc_set_papr':
target-ppc/kvm.c:1504:21: error: comparison of unsigned expression < 0 is 
always false [-Werror=type-limits]

However - thanks to Thomas Huth for the suggestion - we can just cast the
offending potentially 0 value to a signed type, making the comparison signed.

Signed-off-by: Alexander Graf <address@hidden>

Mind if I take this through s390-next instead of your tree, so I can
send a pull request with clean conscience?


Sure, whoever hits master first wins ;)


Alex




reply via email to

[Prev in Thread] Current Thread [Next in Thread]