[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 1/9] kvm: Fix enable_cap helpers on older gcc
From: |
Cornelia Huck |
Subject: |
[Qemu-devel] [PULL 1/9] kvm: Fix enable_cap helpers on older gcc |
Date: |
Tue, 20 May 2014 13:44:54 +0200 |
From: Alexander Graf <address@hidden>
Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on
vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6)
seem to choke on signedness detection in inline created variables:
target-ppc/kvm.c: In function 'kvmppc_booke_watchdog_enable':
target-ppc/kvm.c:1302:21: error: comparison of unsigned expression < 0 is
always false [-Werror=type-limits]
target-ppc/kvm.c: In function 'kvmppc_set_papr':
target-ppc/kvm.c:1504:21: error: comparison of unsigned expression < 0 is
always false [-Werror=type-limits]
However - thanks to Thomas Huth for the suggestion - we can just cast the
offending potentially 0 value to a signed type, making the comparison signed.
Reviewed-by: Thomas Huth <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
include/sysemu/kvm.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/sysemu/kvm.h b/include/sysemu/kvm.h
index e7ad9d1..25c8a2b 100644
--- a/include/sysemu/kvm.h
+++ b/include/sysemu/kvm.h
@@ -300,7 +300,7 @@ int kvm_check_extension(KVMState *s, unsigned int
extension);
}; \
uint64_t args_tmp[] = { __VA_ARGS__ }; \
int i; \
- for (i = 0; i < ARRAY_SIZE(args_tmp) && \
+ for (i = 0; i < (int)ARRAY_SIZE(args_tmp) && \
i < ARRAY_SIZE(cap.args); i++) { \
cap.args[i] = args_tmp[i]; \
} \
@@ -315,7 +315,7 @@ int kvm_check_extension(KVMState *s, unsigned int
extension);
}; \
uint64_t args_tmp[] = { __VA_ARGS__ }; \
int i; \
- for (i = 0; i < ARRAY_SIZE(args_tmp) && \
+ for (i = 0; i < (int)ARRAY_SIZE(args_tmp) && \
i < ARRAY_SIZE(cap.args); i++) { \
cap.args[i] = args_tmp[i]; \
} \
--
1.7.9.5
- [Qemu-devel] [PULL 0/9] s390 patches for 2014/05/20, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 2/9] s390x: split flic into kvm and non-kvm parts, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 1/9] kvm: Fix enable_cap helpers on older gcc,
Cornelia Huck <=
- [Qemu-devel] [PULL 3/9] s390x: add I/O adapter registration, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 8/9] s390x/kvm: software breakpoint support, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 7/9] s390x: remove duplicate definitions of DIAG 501, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 6/9] linux-headers: update, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 4/9] s390x/virtio-ccw: reference-counted indicators, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 5/9] s390x/virtio-ccw: wire up irq routing and irqfds, Cornelia Huck, 2014/05/20
- [Qemu-devel] [PULL 9/9] s390x/kvm: hw debugging support via guest PER facility, Cornelia Huck, 2014/05/20
- Re: [Qemu-devel] [PULL 0/9] s390 patches for 2014/05/20, Peter Maydell, 2014/05/22