qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)


From: Paolo Bonzini
Subject: Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps)
Date: Tue, 20 May 2014 14:56:15 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0

Il 20/05/2014 13:39, Laszlo Ersek ha scritto:
In March Paolo and Luiz had some comments for upstream qemu while they
were reviewing my downstream port of Qiao Nuohan's compressed
(kdump-format) dump feature. I've finally got around addressing them.

Laszlo Ersek (7):
  dump: fill in the flat header signature more pleasingly to the eye
  dump: simplify write_start_flat_header()
  dump: eliminate DumpState.page_shift ("guest's page shift")
  dump: eliminate DumpState.page_size ("guest's page size")
  dump: select header bitness based on ELF class, not ELF architecture
  dump: hoist lzo_init() from get_len_buf_out() to dump_init()
  dump: simplify get_len_buf_out()

 include/sysemu/dump.h |   8 +--
 dump.c                | 142 ++++++++++++++++++++++----------------------------
 2 files changed, 65 insertions(+), 85 deletions(-)


I would have a slight preference for QEMU_BUILD_BUG_ON instead of MIN in patch 1, but that's a really minor nit.

Reviewed-by: Paolo Bonzini <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]