[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsf
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v2] qga: Add 'mountpoints' argument to guest-fsfreeze-freeze command |
Date: |
Tue, 20 May 2014 09:45:06 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 04/28/2014 09:25 AM, Tomoki Sekiyama wrote:
> When an array of mount point paths is specified as 'mountpoints' argument
> of guest-fsfreeze-freeze, qemu-ga with this patch will only freeze the file
> systems mounted on specified paths in Linux.
How does the management application learn the set of valid mountpoints
arguments it can pass to this command? Shouldn't there be a query
counterpart that asks the guest to return the full list of mountpoints
that it can support freezing? In the case of guests that are
all-or-none, like Windows, the query command would return an empty list
to make it obvious there is no ability to freeze just a subset.
In returning a list of mountpoint names, it might also be nice to
correlate which names map to which devices (it can be a many:many
mapping, thanks to things like RAID setups in the guest).
> This would be useful when the host wants to create partial disk snapshots.
>
> Signed-off-by: Tomoki Sekiyama <address@hidden>
> ---
> qga/commands-posix.c | 17 ++++++++++++++++-
> qga/commands-win32.c | 3 ++-
> qga/qapi-schema.json | 4 ++++
> 3 files changed, 22 insertions(+), 2 deletions(-)
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature