Re: [Qemu-devel] [PATCH 6/6] python script for extracting bitmap from a binary file

[Eric Blake]

On 05/20/2014 11:47 AM, Sanidhya Kashyap wrote:
> This script extracts the bitmap only from a binary file. It takes only
> a single input as file. This will be useful to users for exploring the
> writable working set for the VM.
> 
> Signed-off-by: Sanidhya Kashyap <address@hidden>
> ---
>  scripts/extract-bitmap.py | 68 
> +++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 68 insertions(+)
>  create mode 100755 scripts/extract-bitmap.py
> 
> diff --git a/scripts/extract-bitmap.py b/scripts/extract-bitmap.py
> new file mode 100755
> index 0000000..64ce136
> --- /dev/null
> +++ b/scripts/extract-bitmap.py
> @@ -0,0 +1,68 @@
> +#!/usr/bin/python
> +# This python script helps in extracting the dirty bitmap present
> +# in the file after executing the log-dirty-bitmap command either
> +# from the qmp or hmp interface. This file only processes binary
> +# file obtained via command.
> +#
> +# Copyright (C) Sanidhya Kashyap <address@hidden>

Worth listing 2014?

> +#
> +# Authors:
> +#       Sanidhya Kashyap
> +#
> +# This program is distributed in the hope that it will be useful,
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +# GNU General Public License for more details.
> +#
> +# You should have received a copy of the GNU General Public License along
> +# with this program; if not, see <http://www.gnu.org/licenses/>.

You refer to the GPL, but didn't explicitly state what license this file
is under.  Did you mean for it to be GPLv2+?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature