[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2
From: |
Edgar E. Iglesias |
Subject: |
Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2 |
Date: |
Wed, 21 May 2014 01:01:28 +0000 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, May 20, 2014 at 07:02:37PM +1000, Peter Crosthwaite wrote:
> On Mon, May 19, 2014 at 7:23 PM, Edgar E. Iglesias
> <address@hidden> wrote:
> > From: "Edgar E. Iglesias" <address@hidden>
> >
> > Signed-off-by: Edgar E. Iglesias <address@hidden>
> > ---
> > target-arm/cpu.h | 2 +-
> > target-arm/helper.c | 20 ++++++++++++++++++++
> > 2 files changed, 21 insertions(+), 1 deletion(-)
> >
> > diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> > index 7322e03..693ad0f 100644
> > --- a/target-arm/cpu.h
> > +++ b/target-arm/cpu.h
> > @@ -198,7 +198,7 @@ typedef struct CPUARMState {
> > uint32_t c9_pmuserenr; /* perf monitor user enable */
> > uint32_t c9_pminten; /* perf monitor interrupt enables */
> > uint64_t mair_el1;
> > - uint64_t vbar_el[2]; /* vector base address register */
> > + uint64_t vbar_el[3]; /* vector base address register */
> > uint32_t c13_fcse; /* FCSE PID. */
> > uint64_t contextidr_el1; /* Context ID. */
> > uint64_t tpidr_el0; /* User RW Thread register. */
> > diff --git a/target-arm/helper.c b/target-arm/helper.c
> > index 5a2073e..7ca63a8 100644
> > --- a/target-arm/helper.c
> > +++ b/target-arm/helper.c
> > @@ -2077,6 +2077,15 @@ static const ARMCPRegInfo v8_cp_reginfo[] = {
> > REGINFO_SENTINEL
> > };
> >
> > +/* Used to describe the behaviour of EL2 regs when EL2 does not exist. */
> > +static const ARMCPRegInfo v8_no_el2_cp_reginfo[] = {
>
> Should it be v8_el3_no_el2_cp_reginfo?
I've changed it to v8_el3_no_el2_cp_reginfo.
Thanks,
Edgar
>
> Otherwise,
>
> Reviewed-by: Peter Crosthwaite <address@hidden>
- Re: [Qemu-devel] [PATCH v3 15/22] target-arm: A64: Forbid ERET to unimplemented ELs, (continued)
- [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 17/22] target-arm: A64: Generalize update_spsel for the various ELs, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 18/22] target-arm: Make vbar_write writeback to any CPREG, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 20/22] target-arm: A64: Register VBAR_EL3, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 21/22] RFC: target-arm: A32: Use get_mem_index for load/stores, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index, Edgar E. Iglesias, 2014/05/19