[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2 |
Date: |
Wed, 21 May 2014 20:22:27 +0100 |
On 19 May 2014 10:23, Edgar E. Iglesias <address@hidden> wrote:
> From: "Edgar E. Iglesias" <address@hidden>
>
> Signed-off-by: Edgar E. Iglesias <address@hidden>
> @@ -2356,6 +2370,12 @@ void register_cp_regs_for_features(ARMCPU *cpu)
> }
> if (arm_feature(env, ARM_FEATURE_EL2)) {
> define_arm_cp_regs(cpu, v8_el2_cp_reginfo);
> + } else {
> + /* If EL2 is missing but higher ELs are enabled, we need to
> + * register the no_el2 reginfos. */
Very nitpicky, but my preferred multiline comment style puts the
final "*/" on its own line rather than at the end of the preceding.
> + if (arm_feature(env, ARM_FEATURE_EL3)) {
> + define_arm_cp_regs(cpu, v8_no_el2_cp_reginfo);
> + }
> }
> if (arm_feature(env, ARM_FEATURE_EL3)) {
> define_arm_cp_regs(cpu, v8_el3_cp_reginfo);
> --
> 1.8.3.2
thanks
-- PMM
- [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs, (continued)
- [Qemu-devel] [PATCH v3 16/22] target-arm: A64: Generalize ERET to various ELs, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 17/22] target-arm: A64: Generalize update_spsel for the various ELs, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 18/22] target-arm: Make vbar_write writeback to any CPREG, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 19/22] target-arm: A64: Register VBAR_EL2, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 20/22] target-arm: A64: Register VBAR_EL3, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 21/22] RFC: target-arm: A32: Use get_mem_index for load/stores, Edgar E. Iglesias, 2014/05/19
- [Qemu-devel] [PATCH v3 22/22] RFC: target-arm: Use a 1:1 mapping between EL and MMU index, Edgar E. Iglesias, 2014/05/19