[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NON
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH] vnc: refuse to set a password with VNC_AUTH_NONE |
|
Date: |
Thu, 22 May 2014 07:47:03 +0200 |
On Do, 2014-05-22 at 04:05 +0000, Gonglei (Arei) wrote:
> > -----Original Message-----
> > From: address@hidden
> > [mailto:address@hidden On
> > Behalf Of Gerd Hoffmann
> > Sent: Wednesday, May 21, 2014 6:54 PM
> > To: address@hidden
> > Cc: Gerd Hoffmann; Anthony Liguori
> > Subject: [Qemu-devel] [PATCH] vnc: refuse to set a password with
> > VNC_AUTH_NONE
> >
> > Current code silently changes the authentication settings
> > in case you try to set a password without password authentication
> > turned on. This is bad. Return an error instead.
> >
> > If we want allow changing auth settings at runtime this should
> > be done explicitly using a separate monitor command, not as
> > side effect of set_passwd.
> >
> Agreed. Do you have a plan to do this? Thanks.
No, unless someone comes up with a reasonable use case for this.
cheers,
Gerd