Re: [Qemu-devel] [PATCH 00/25] qemu gtk ui overhaul

[Gerd Hoffmann]

  Hi,

> I noticed that some issues with the old code still exist: when "Show
> tabs" is enabled and disabled again, QEMU adds some black scan lines at
> the top of the VGA screen. This can be easily reproduced.

Easily fixed, was just a missing "gd_update_windowsize" call.

> Another small
> problem is "Zoom To Fit" which sometimes changes the display even if it
> was optimal before (more difficult to reproduce).

Changes in what way?

> "Fullscreen" shows some new issues with your code (tested on a 1024x600
> Linux netbook). With Alt+Ctrl+F in non detached compatmonitor0 I get a
> display which continuously switches from fullscreen to non fullscreen.

Hmm, doesn't reproduce here.

> In detached mode, a fullscreen VGA display shows some white scan lines
> at the top.

I suspect this is the menu bar.  Current code tries to hide it by
forcing the widget size to 0x0.  In gtk2 this results in a small white
line at the top of the screen, probably because the minimum widget size
in gtk is 1x1.  In gtk3 this doesn't work at all and the menu bar
remains visible.  This isn't a new issue btw.

I've tried to fix that with a simple gtk_widget_hide(menu_bar) call.
Which has the side effect to also turn off all menu accelerators.  Which
is a non-starter, especially for Ctrl-Alt-F not working any more.

If someone has an idea how to tackle this, I'm all ears.

> It would be nice to have scroll bars when necessary. On my
> small display it is no longer possible to see the whole compatmonitor0
> contents (it's larger than my display, zooming or resizing the window
> does not work and there are no scroll bars).

Try setting the VC_TERM_{X,Y}_MIN defines at the top of gtk.c to
something smaller.  Then you should be able to make the vte tabs small
enough that they fit onto the screen.

Making the terminal font configurable is probably a good idea too.

cheers,
  Gerd