Re: [Qemu-devel] [PATCH v2 01/23] target-arm: add new CPU feature for Security Extensions

[Aggeler Fabian]

On 21 May 2014, at 16:51, Peter Maydell <address@hidden> wrote:

> On 13 May 2014 17:15, Fabian Aggeler <address@hidden> wrote:
>> --- a/target-arm/cpu.h
>> +++ b/target-arm/cpu.h
>> @@ -631,6 +631,7 @@ enum arm_features {
>>     ARM_FEATURE_CBAR, /* has cp15 CBAR */
>>     ARM_FEATURE_CRC, /* ARMv8 CRC instructions */
>>     ARM_FEATURE_CBAR_RO, /* has cp15 CBAR and it is read-only */
>> +    ARM_FEATURE_SECURITY_EXTENSIONS, /* has Security Extensions */
>> };
> 
> Also this feature name is pretty long and unwieldy; something
> shorter would be nice. I think we should probably go with
> ARM_FEATURE_EL2/ARM_FEATURE_EL3 as per Edgar's
> patchset.
> 
> thanks
> -- PMM

Makes sense, I will use Edgar’s ARM_FEATURE_EL3 in the next version.

Fabian