[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 3/7] iotests: Add default common.env
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v3 3/7] iotests: Add default common.env |
Date: |
Fri, 23 May 2014 15:33:26 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Eric Blake <address@hidden> writes:
> On 05/23/2014 12:10 AM, Fam Zheng wrote:
>> On Thu, 05/22 23:30, Max Reitz wrote:
>>> Add a default common.env in case the one supposed to be emitted by
>>> configure cannot be found.
>>>
>>> Signed-off-by: Max Reitz <address@hidden>
>>
>> Now we can run both from in-tree build and out-of-tree build without this,
>> which is already very good, but we need this patch to run from the source
>> tree
>> with an out-of-tree build. I'm not sure we really need that, though.
>
> If you have a source tree but no in-tree build, then there is no way to
> know how many out-of-tree builds there are, or which one you should
> pick. If you are going to do out-of-tree builds, you aren't going to
> try to run tests from the source tree.
Let's not try to guess a build tree.
If someone tries to run tests in the source tree, and the source tree
has not been made a build tree by running configure there, simply fail.
[Qemu-devel] [PATCH v3 4/7] iotests: Source common.env, Max Reitz, 2014/05/22
[Qemu-devel] [PATCH v3 5/7] iotests: Use $PYTHON for Python scripts, Max Reitz, 2014/05/22
[Qemu-devel] [PATCH v3 6/7] iotests: Drop Python version from 065's Shebang, Max Reitz, 2014/05/22
[Qemu-devel] [PATCH v3 7/7] iotests: Fix 083 for out-of-tree builds, Max Reitz, 2014/05/22