[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 01/13] cputlb: Fix regression with TCG interpreter (
From: |
Paolo Bonzini |
Subject: |
[Qemu-devel] [PATCH 01/13] cputlb: Fix regression with TCG interpreter (bug 1310324) |
Date: |
Fri, 23 May 2014 17:20:45 +0200 |
From: Stefan Weil <address@hidden>
Commit 0f842f8a246f2b5b51a11c13f933bf7a90ae8e96 replaced GETPC_EXT() which
was derived from GETPC() by GETRA_EXT() without fixing cputlb.c. A later
patch replaced GETRA_EXT() by GETRA() in exec/softmmu_template.h which
is included in cputlb.c.
The TCG interpreter failed because the values returned by GETRA() were no
longer explicitly set to 0. The redefinition of GETRA() introduced here
fixes this.
In addition, GETPC_ADJ which is also used in exec/softmmu_template.h is
set to 0. Both changes reduce the compiled code size for cputlb.c by more
than 100 bytes, so the normal TCG without interpreter also profits from
the reduced code size and slightly faster code.
Cc: address@hidden
Reported-by: Giovanni Mascellani <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
---
cputlb.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/cputlb.c b/cputlb.c
index 7bd3573..214c945 100644
--- a/cputlb.c
+++ b/cputlb.c
@@ -331,8 +331,10 @@ tb_page_addr_t get_page_addr_code(CPUArchState *env1,
target_ulong addr)
}
#define MMUSUFFIX _cmmu
-#undef GETPC
-#define GETPC() ((uintptr_t)0)
+#undef GETPC_ADJ
+#define GETPC_ADJ 0
+#undef GETRA
+#define GETRA() ((uintptr_t)0)
#define SOFTMMU_CODE_ACCESS
#define SHIFT 0
--
1.7.1
- [Qemu-devel] [PATCH 00/13] Cleanup load/store functions in headers and C files, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 01/13] cputlb: Fix regression with TCG interpreter (bug 1310324),
Paolo Bonzini <=
- [Qemu-devel] [PATCH 02/13] nseries: clean up coding style, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 04/13] softmmu: start introducing SOFTMMU_CODE_ACCESS in softmmu_header.h, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 03/13] hw: use ld_p/st_p instead of ld_raw/st_raw, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 06/13] softmmu: move definition of CPU_MMU_INDEX to inclusion site, drop ACCESS_TYPE, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 05/13] softmmu: move MMUSUFFIX under SOFTMMU_CODE_ACCESS, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 08/13] softmmu: move ALIGNED_ONLY to cpu.h, Paolo Bonzini, 2014/05/23
- [Qemu-devel] [PATCH 07/13] softmmu: make do_unaligned_access a method of CPU, Paolo Bonzini, 2014/05/23