[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039 |
Date: |
Mon, 26 May 2014 11:10:44 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
Kevin Wolf <address@hidden> writes:
> Am 14.05.2014 um 15:28 hat Fam Zheng geschrieben:
>> On Wed, 05/14 15:12, Markus Armbruster wrote:
>> > The shell script attempts to suppress core dumps like this:
>> >
>> > old_ulimit=$(ulimit -c)
>> > ulimit -c 0
>> > $QEMU_IO arg...
>> > ulimit -c "$old_ulimit"
>> >
>> > This breaks the test hard unless the limit was zero to begin with!
>> > ulimit sets both hard and soft limit by default, and (re-)raising the
>> > hard limit requires privileges. Broken since it was added in commit
>> > dc68afe.
>> >
>> > Could be fixed by adding -S to set only the soft limit, but I'm not
>> > sure how portable that is in practice. Simply do it in a subshell
>> > instead, like this:
>> >
>> > (ulimit -c 0; exec $QEMU_IO arg...)
>> >
>> > Signed-off-by: Markus Armbruster <address@hidden>
>>
>> Reviewed-by: Fam Zheng <address@hidden>
>
> Thanks, applied to the block branch.
I just got this on a system with abrt installed:
039 3s ... - output mismatch (see 039.out.bad)
--- 039.out 2014-05-23 11:45:22.436540656 +0200
+++ 039.out.bad 2014-05-26 11:06:37.757516376 +0200
@@ -11,7 +11,7 @@
Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=134217728
wrote 512/512 bytes at offset 0
512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-./039: Aborted ( ulimit -c 0; exec "$@" )
+./039: Aborted (core dumped) ( ulimit -c 0; exec "$@" )
incompatible_features 0x1
ERROR cluster 5 refcount=0 reference=1
ERROR OFLAG_COPIED data cluster: l2_entry=8000000000050000 refcount=0
[...]
I immediately erased abrt, as I have no use for it.
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, (continued)
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Markus Armbruster, 2014/05/13
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Eric Blake, 2014/05/13
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Kevin Wolf, 2014/05/14
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Markus Armbruster, 2014/05/14
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Markus Armbruster, 2014/05/14
- Re: [Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Kevin Wolf, 2014/05/14
[Qemu-devel] [PATCH] qemu-iotests: Fix core dump suppression in test 039, Markus Armbruster, 2014/05/14